Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 4e43347b2d | |||
| ec9ddb09a7 |
@@ -299,14 +299,19 @@ touching anything.
|
|||||||
- **Prompt:** `Use any eligible merger profile to merge PR #N if checks pass and
|
- **Prompt:** `Use any eligible merger profile to merge PR #N if checks pass and
|
||||||
it is mergeable. Confirm with "MERGE PR N". Do not force-merge.`
|
it is mergeable. Confirm with "MERGE PR N". Do not force-merge.`
|
||||||
|
|
||||||
### Close the issue after merge
|
### Close the issue after merge / Reconciliation
|
||||||
|
|
||||||
- **Profile:** issue-manager or merger.
|
- **Profile:** issue-manager or merger.
|
||||||
- **Steps:** verify remote `master` actually contains the merge; close the
|
- **Steps:** verify remote `master` actually contains the merge; close the
|
||||||
issue (or rely on a `Closes #N` keyword); release `status:in-progress`;
|
issue; release `status:in-progress` (if it cannot be removed, report why).
|
||||||
clean up merged branches.
|
- **If closed but not merged (`merged=false`):** Stop normal flow. Do not delete worktrees. Compare PR content to remote `master`.
|
||||||
- **Prompt:** `After confirming master contains the merge of PR #N, close issue
|
- **fully landed:** comment it landed, remove `status:in-progress`, clean up.
|
||||||
#M and delete the merged branch.`
|
- **partially landed:** reopen issue, create corrective PR for missing pieces.
|
||||||
|
- **not landed:** reopen issue/PR, do not clean up.
|
||||||
|
- **Direct push to master:** is forbidden except as a documented recovery exception. Final reports must include why, commits, PR metadata, and repaired labels.
|
||||||
|
- **Final reports:** must include both PR metadata (state, merged flag, merge commit) and Git content (remote master hash, expected content present).
|
||||||
|
- **Prompt (normal):** `After confirming master contains the merge of PR #N, close issue #M and delete the merged branch.`
|
||||||
|
- **Prompt (reconcile):** `Reconcile closed-not-merged PR #N by verifying if its content landed on master.`
|
||||||
|
|
||||||
### Stop on blocker
|
### Stop on blocker
|
||||||
|
|
||||||
|
|||||||
@@ -19,6 +19,14 @@ identity, and cleaned up only after a real merge.
|
|||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|
||||||
|
## Definitions
|
||||||
|
|
||||||
|
- **Merged**: Gitea PR metadata says `merged=true`.
|
||||||
|
- **Landed**: Equivalent content is present on remote `master`, but PR metadata may not say merged.
|
||||||
|
- **Closed-not-merged**: PR state is closed and `merged=false`.
|
||||||
|
- **Reconciled**: A human/LLM verified whether closed-not-merged content landed, partially landed, or was lost, and repaired issue/label/tracker state.
|
||||||
|
|
||||||
## A. Issue-first rule
|
## A. Issue-first rule
|
||||||
|
|
||||||
**No repository change without a tracking issue.** This includes creating,
|
**No repository change without a tracking issue.** This includes creating,
|
||||||
@@ -133,6 +141,14 @@ Worktree folder = branch with `/` replaced by `-`
|
|||||||
10. Push the branch.
|
10. Push the branch.
|
||||||
11. Open a PR to `master`.
|
11. Open a PR to `master`.
|
||||||
12. **If you are the author, stop before review/merge.**
|
12. **If you are the author, stop before review/merge.**
|
||||||
|
13. **Normal issue work must not directly push to `master`.** PR content should be merged through the forge PR merge mechanism.
|
||||||
|
14. Direct push to `master` is allowed only as a documented recovery exception. If used, the final report must include:
|
||||||
|
- why the PR merge path could not be used
|
||||||
|
- exact commits pushed
|
||||||
|
- PR metadata state
|
||||||
|
- issue labels/state repaired
|
||||||
|
- whether the PR is closed-not-merged
|
||||||
|
|
||||||
|
|
||||||
## F. Review workflow
|
## F. Review workflow
|
||||||
|
|
||||||
@@ -148,13 +164,15 @@ Worktree folder = branch with `/` replaced by `-`
|
|||||||
|
|
||||||
Only an eligible (non-author) reviewer merges. After a real merge:
|
Only an eligible (non-author) reviewer merges. After a real merge:
|
||||||
|
|
||||||
1. Confirm remote `master` actually contains the merge commit.
|
1. Confirm remote `master` actually contains the merge commit (A PR is not done just because `master` moved. A PR is done only when: Gitea reports the PR merged or reconciliation documents equivalent content on `master`; remote `master` contains the expected content; linked issues are closed; `status:in-progress` is removed).
|
||||||
2. Close/release the issue; remove `status:in-progress` if used.
|
2. Close/release the issue.
|
||||||
3. Delete the remote branch.
|
3. Whenever an issue is closed, check for `status:in-progress`: remove it, or report why it could not be removed.
|
||||||
4. Remove the local branch.
|
4. Do not delete the remote source branch until: PR `merged=true`, or reconciliation confirms content is safely landed, or the issue owner explicitly abandons the work.
|
||||||
5. Remove the branch worktree folder (`scripts/worktree-clean --delete-branch <branch>`).
|
5. Remove the local branch.
|
||||||
6. Fetch/prune.
|
6. Remove the branch worktree folder (`scripts/worktree-clean --delete-branch <branch>`). Branches/worktrees are cleaned only after the above is verified.
|
||||||
7. Confirm the main checkout is clean and current (`0 0` vs remote).
|
7. Fetch/prune.
|
||||||
|
8. Confirm the main checkout is clean and current (`0 0` vs remote).
|
||||||
|
9. Final merge/reconciliation reports must include both: PR metadata (state, merged flag, merge commit/hash) and Git content (remote master hash, expected content present or not).
|
||||||
|
|
||||||
Never run cleanup before the merge is confirmed on remote `master`.
|
Never run cleanup before the merge is confirmed on remote `master`.
|
||||||
|
|
||||||
@@ -165,7 +183,11 @@ Never run cleanup before the merge is confirmed on remote `master`.
|
|||||||
- No issue exists and one cannot be created.
|
- No issue exists and one cannot be created.
|
||||||
- Worktree state is unclear or unexpected.
|
- Worktree state is unclear or unexpected.
|
||||||
- Branch/PR state conflicts with the prompt (e.g. prompt says "merged" but it is not).
|
- Branch/PR state conflicts with the prompt (e.g. prompt says "merged" but it is not).
|
||||||
- A PR is closed but not merged.
|
- A PR is closed but not merged (closed with `merged=false`). In this case:
|
||||||
|
- stop normal review/merge
|
||||||
|
- do not delete branches/worktrees
|
||||||
|
- do not start dependent work
|
||||||
|
- run reconciliation
|
||||||
- Local `master` is ahead of remote unexpectedly.
|
- Local `master` is ahead of remote unexpectedly.
|
||||||
- The authenticated user is the PR author (for review/merge).
|
- The authenticated user is the PR author (for review/merge).
|
||||||
- Secrets/tokens appear in the diff.
|
- Secrets/tokens appear in the diff.
|
||||||
@@ -182,9 +204,10 @@ When in doubt, stop and surface the discrepancy; do not guess or work around a g
|
|||||||
the commits are preserved on a feature branch (local + remote) first, then
|
the commits are preserved on a feature branch (local + remote) first, then
|
||||||
`git reset --hard <remote>/master` to realign. Never discard commits that are
|
`git reset --hard <remote>/master` to realign. Never discard commits that are
|
||||||
not safely pushed elsewhere.
|
not safely pushed elsewhere.
|
||||||
- **PR closed but not merged:** the work is not in mainline. Re-push the branch,
|
- **PR closed but not merged (`merged=false`):** do not merge. Run reconciliation: compare PR content to remote `master` and decide:
|
||||||
reopen (or open a replacement) PR, and let an eligible reviewer merge. Do not
|
- **fully landed:** comment that content is present on `master`, remove `status:in-progress`, keep/close issue as appropriate, clean up only after content equivalence is confirmed.
|
||||||
assume "closed" means "merged" — verify remote `master` contains the commits.
|
- **partially landed:** do not clean up, reopen issue if needed, create corrective issue/PR for missing pieces.
|
||||||
|
- **not landed:** reopen issue if needed, reopen PR or create replacement PR, do not clean up source branch/worktree.
|
||||||
- **Branch deleted before merge:** if the commits still exist locally (a branch or
|
- **Branch deleted before merge:** if the commits still exist locally (a branch or
|
||||||
reflog), re-push them and reopen the PR; otherwise recover via
|
reflog), re-push them and reopen the PR; otherwise recover via
|
||||||
`git fsck --lost-found`. Preserve first, then proceed.
|
`git fsck --lost-found`. Preserve first, then proceed.
|
||||||
@@ -203,6 +226,7 @@ Ready-to-copy templates live in [`templates/`](templates/):
|
|||||||
- [`review-pr.md`](templates/review-pr.md) — review a PR.
|
- [`review-pr.md`](templates/review-pr.md) — review a PR.
|
||||||
- [`merge-pr.md`](templates/merge-pr.md) — merge a PR (eligible reviewer only).
|
- [`merge-pr.md`](templates/merge-pr.md) — merge a PR (eligible reviewer only).
|
||||||
- [`recover-bad-state.md`](templates/recover-bad-state.md) — recover from bad state.
|
- [`recover-bad-state.md`](templates/recover-bad-state.md) — recover from bad state.
|
||||||
|
- [`reconcile-closed-not-merged-pr.md`](templates/reconcile-closed-not-merged-pr.md) — reconcile a closed-not-merged PR.
|
||||||
- [`worktree-cleanup.md`](templates/worktree-cleanup.md) — clean up after merge.
|
- [`worktree-cleanup.md`](templates/worktree-cleanup.md) — clean up after merge.
|
||||||
- [`release-tag.md`](templates/release-tag.md) — create a release tag.
|
- [`release-tag.md`](templates/release-tag.md) — create a release tag.
|
||||||
|
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ Rules (llm-project-workflow):
|
|||||||
author → STOP.
|
author → STOP.
|
||||||
- Do not merge unless the PR is open, mergeable, and its checks/review pass.
|
- Do not merge unless the PR is open, mergeable, and its checks/review pass.
|
||||||
- No force-merge, no bypassing branch protections.
|
- No force-merge, no bypassing branch protections.
|
||||||
|
- If the PR is closed but `merged=false`, STOP and run reconciliation. Do not clean up.
|
||||||
|
|
||||||
Steps:
|
Steps:
|
||||||
1. Verify authenticated identity + active profile.
|
1. Verify authenticated identity + active profile.
|
||||||
@@ -20,9 +21,9 @@ Steps:
|
|||||||
5. Confirm remote master now contains the merge commit.
|
5. Confirm remote master now contains the merge commit.
|
||||||
|
|
||||||
Then run the cleanup template (worktree-cleanup.md):
|
Then run the cleanup template (worktree-cleanup.md):
|
||||||
- close/release issue #<n>, remove status:in-progress
|
- close/release issue #<n>, remove status:in-progress (if it cannot be removed, report why)
|
||||||
- delete remote branch, remove local branch + worktree folder
|
- delete remote branch, remove local branch + worktree folder
|
||||||
- fetch/prune; confirm main checkout is clean and current (0 0).
|
- fetch/prune; confirm main checkout is clean and current (0 0).
|
||||||
|
|
||||||
Handoff: reviewer identity, merge result + commit, cleanup done, issue closed.
|
Handoff: reviewer identity, merge result + commit, cleanup done, issue closed, PR metadata state/merged flag/hash, remote master hash & Git content check.
|
||||||
```
|
```
|
||||||
|
|||||||
@@ -0,0 +1,24 @@
|
|||||||
|
# Reconcile Closed-Not-Merged PR Prompt
|
||||||
|
|
||||||
|
You are reconciling PR `<pr-number>` in `<repo-name>` which is closed but `merged=false`.
|
||||||
|
|
||||||
|
Rules:
|
||||||
|
|
||||||
|
- Do not delete branches or worktrees before reconciliation is complete.
|
||||||
|
- Compare the PR's exact content to remote `<default-branch>`.
|
||||||
|
- Determine if the content is fully landed, partially landed, or not landed.
|
||||||
|
|
||||||
|
Workflow:
|
||||||
|
|
||||||
|
1. Verify the PR metadata says `state=closed` and `merged=false`.
|
||||||
|
2. Fetch/prune and inspect remote `<default-branch>`.
|
||||||
|
3. If fully landed: comment that it landed, remove `status:in-progress`, close issue, and clean up.
|
||||||
|
4. If partially landed: reopen issue if needed, create corrective PR for missing pieces, do not clean up.
|
||||||
|
5. If not landed: reopen issue/PR, do not clean up.
|
||||||
|
|
||||||
|
Final handoff:
|
||||||
|
|
||||||
|
- PR metadata (state, merged flag, hash)
|
||||||
|
- Git content verification (remote master hash, expected content present or not)
|
||||||
|
- reconciliation decision (fully/partially/not landed)
|
||||||
|
- issue/label state repaired
|
||||||
@@ -22,8 +22,7 @@ Act per case:
|
|||||||
- Local master ahead of remote: confirm the extra commits live on a branch
|
- Local master ahead of remote: confirm the extra commits live on a branch
|
||||||
pushed to <remote>, THEN git reset --hard <remote>/master. Verify with
|
pushed to <remote>, THEN git reset --hard <remote>/master. Verify with
|
||||||
`git branch --contains <sha>` first.
|
`git branch --contains <sha>` first.
|
||||||
- PR closed but not merged: re-push the branch, reopen/replace the PR, let an
|
- PR closed but not merged (`merged=false`): stop normal flow and use reconcile-closed-not-merged-pr.md instead.
|
||||||
eligible reviewer merge. Do not merge your own.
|
|
||||||
- Branch deleted before merge: recover commits from a local branch/reflog (or
|
- Branch deleted before merge: recover commits from a local branch/reflog (or
|
||||||
git fsck --lost-found), re-push, reopen the PR.
|
git fsck --lost-found), re-push, reopen the PR.
|
||||||
- Unauthorized untracked file: do not commit it; leave pre-existing artifacts.
|
- Unauthorized untracked file: do not commit it; leave pre-existing artifacts.
|
||||||
|
|||||||
Reference in New Issue
Block a user