Reviewer runs that observe a validation failure and later rerun to green
must report the failure and its investigation; a later pass never erases
the earlier failure:
- New reviewer_validation_failure_history.py verifier: reports must carry
a Validation failure history section naming every observed failure with
command, failing test or error, suspected cause, reproduced status,
baseline master status, and PR-caused evidence; rerun-pass claims must
explain what changed between runs, whether environmental state (such as
stale /tmp files) was cleaned, and why the pass is trustworthy; an
unexplained transient failure cannot be reported as a bare pass and
must use the status 'passed after transient failure investigation'
(exported as TRANSIENT_INVESTIGATION_STATUS).
- Re-export from review_proofs and wire into build_final_report as a
downgrade check.
- Review-merge final-report schema gains the Validation failure history
template section; contract test locks the markers and an export test
locks the re-export.
- 12 tests covering the issue's scenarios: failing-then-passing rerun,
baseline-equivalent failure, /tmp state contamination, unexplained
transient failure, and a report omitting an earlier failure.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Adds canonical pr-queue-cleanup workflow, report verifier, reviewer-only task
routing, and runbook guidance so operators can drain open PRs one canonical
review at a time with fail-closed boundaries on batching and unauthorized merges.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Add assess_queue_status_report and assess_proof_wording to reject
contradictory queue-status-only reports: passed gates without a selected
PR, prior diagnostic conflict proof, pagination assumptions, and
blocker contradictions. Wire into build_final_report and document the
queue-status-only schema path.
Closes#339
Consolidate all four canonical workflow files and router SKILL.md:
- review-merge-pr.md (from #334 canonical prompt)
- reconcile-landed-pr.md (reconciliation gates + handoff schema)
- create-issue.md (canonical issue-creation prompt)
- work-issue.md (canonical author/coder prompt)
SKILL.md is now a short router with mode isolation and universal rules.
Adds final-report schemas for all modes and 13 doc-contract tests.
Supersedes partial split work in PR #335; full #333 acceptance in one PR.
sysadminandClaude Opus 4.8