feat: classify already-landed PRs as reconciliation-only (Closes #295)

Add reviewer_already_landed_classification verifier to block oldest/next eligible PR wording, review-eligible claims, and pinned reviewed head usage when a PR is already landed. Wire the check into build_final_report and tighten final_report_validator regex coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
2026-07-07 09:23:50 -04:00
parent 0fe8f57dda
commit f89019f804
6 changed files with 277 additions and 1 deletions
@@ -190,6 +190,20 @@ class TestReviewPrRules(unittest.TestCase):
            )
        )

+    def test_already_landed_oldest_eligible_pr_blocks(self):
+        report = (
+            _review_handoff()
+            + "\nAlready landed.\nOldest eligible PR: PR #278."
+        )
+        result = assess_final_report_validator(report, "review_pr")
+        self.assertTrue(result["blocked"])
+        self.assertTrue(
+            any(
+                f["rule_id"] == "reviewer.already_landed_eligible_wording"
+                for f in result["findings"]
+            )
+        )
+
    def test_git_fetch_must_not_be_readonly_only(self):
        report = (
            _review_handoff()