Initialize review decision lock in test suite to prevent flakiness and resolve test pollution

This commit is contained in:
2026-07-05 17:38:59 -04:00
parent 531ce25c49
commit a1a7c5b30e
3 changed files with 17 additions and 4 deletions
+4 -1
View File
@@ -128,11 +128,14 @@ class TestShaCannotBypassSelfReview(unittest.TestCase):
{"login": "jcwalker3"}, # /user (eligibility)
{"state": "open", "head": {"sha": "abc1234"}, "mergeable": True, "user": {"login": "jcwalker3"}} # /pulls/9 (eligibility)
]
from mcp_server import init_review_decision_lock, gitea_mark_final_review_decision
init_review_decision_lock("prgs", "review_pr")
gitea_mark_final_review_decision(9, "approve", remote="prgs")
env = self._env(SHA_WOULD_BE_REVIEWER, "reviewer")
with patch.dict(os.environ, env, clear=True):
r = gitea_review_pr(
pr_number=9, event="APPROVE", body="self approve", merge=False,
remote="prgs")
remote="prgs", final_review_decision_ready=True)
self.assertFalse(r["success"])
self.assertIn("authenticated user is PR author", r["message"])
for call in mock_api.call_args_list: