From 9d8ab0a7b560930943b0a40984ea3363cc0ae3f8 Mon Sep 17 00:00:00 2001 From: Jason Walker <913443@dadeschools.net> Date: Mon, 6 Jul 2026 12:21:26 -0400 Subject: [PATCH] test: fix PR queue inventory mock for visible APPROVED verification (#244) Update test_reviewer_profile_can_proceed_from_inventory_to_review_gates to return APPROVED state on POST and include GET /reviews verification responses required by #244 review submission gates. Co-Authored-By: Claude Opus 4.8 (1M context) --- tests/test_pr_queue_inventory.py | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/tests/test_pr_queue_inventory.py b/tests/test_pr_queue_inventory.py index 8919cfb..82998a4 100644 --- a/tests/test_pr_queue_inventory.py +++ b/tests/test_pr_queue_inventory.py @@ -119,12 +119,28 @@ class TestPRQueueInventory(unittest.TestCase): mock_get_all.return_value = [ {"number": 1, "title": "PR 1", "state": "open", "head": {"ref": "branch1", "sha": "abc1"}, "base": {"ref": "master"}, "mergeable": True, "user": {"login": "other_user"}} ] - # mock_api: 1) /user (inventory), 2) /user (eligibility), 3) /pulls/1 (eligibility), 4) /pulls/1/reviews (POST review) + # mock_api: inventory whoami, eligibility whoami, eligibility PR, + # POST review (#244: state + visible-verdict GET reviews). mock_api.side_effect = [ - {"login": "reviewer1"}, # inventory whoami - {"login": "reviewer1"}, # submit eligibility whoami - {"user": {"login": "other_user"}, "state": "open", "head": {"sha": "abc1"}, "mergeable": True}, # submit eligibility PR - {"id": 100}, # POST review + {"login": "reviewer1"}, + {"login": "reviewer1"}, + { + "user": {"login": "other_user"}, + "state": "open", + "head": {"sha": "abc1"}, + "mergeable": True, + }, + {"id": 100, "state": "APPROVED"}, + [ + { + "id": 100, + "user": {"login": "reviewer1"}, + "state": "APPROVED", + "commit_id": "abc1", + "submitted_at": "2026-07-06T10:00:00Z", + "dismissed": False, + } + ], ] from mcp_server import init_review_decision_lock, gitea_mark_final_review_decision