Merge pull request 'feat(workflow): pre-task role/session router blocks reviewer tasks in author sessions (Issue #206)' (#217) from feat/issue-206-role-session-router into master

mcp_server.py

@@ -170,6 +170,7 @@ from gitea_auth import (  # noqa: E402
 )
 import gitea_audit  # noqa: E402
 import gitea_config  # noqa: E402
+import role_session_router  # noqa: E402
 
 
 def _reveal_endpoints() -> bool:
@@ -449,6 +450,16 @@ def gitea_create_issue(
     Returns:
         dict with 'number' of the created issue ('url' only with the reveal opt-in).
     """
+    ok, block_reasons = role_session_router.check_author_mutation_after_reviewer_stop(
+        "create_issue"
+    )
+    if not ok:
+        return {
+            "success": False,
+            "performed": False,
+            "number": None,
+            "reasons": block_reasons,
+        }
     h, o, r = _resolve(remote, host, org, repo)
     auth = _auth(h)
     url = f"{repo_api_url(h, o, r)}/issues"
@@ -3467,6 +3478,60 @@ def build_validation_report(commands: list[dict]) -> dict:
     }
 
 
+@mcp.tool()
+def gitea_route_task_session(
+    task_type: str,
+    remote: str = "dadeschools",
+    host: str | None = None,
+) -> dict:
+    """Pre-task role/session router (#206).
+
+    Classify *task_type* against the active MCP profile before any mutation.
+    Returns ``route_result`` — only ``allowed_current_session`` permits
+    downstream tool use. Reviewer tasks under an author-bound session return
+    ``wrong_role_stop`` with no fallback to author mutations.
+    """
+    task_type = (task_type or "").strip()
+    profile = get_profile()
+    allowed = profile.get("allowed_operations") or []
+    forbidden = profile.get("forbidden_operations") or []
+    active_role = _role_kind(allowed, forbidden)
+
+    if not task_type:
+        return role_session_router.route_task_session(
+            "",
+            active_profile=profile["profile_name"],
+            active_role_kind=active_role,
+            allowed_in_current_session=False,
+        )
+
+    capability = None
+    try:
+        capability = gitea_resolve_task_capability(
+            task=task_type,
+            remote=remote,
+            host=host,
+        )
+    except ValueError:
+        capability = None
+
+    if capability is not None:
+        return role_session_router.route_task_session(
+            task_type,
+            active_profile=capability["active_profile"],
+            active_role_kind=active_role,
+            allowed_in_current_session=capability["allowed_in_current_session"],
+            runtime_switching_supported=capability["runtime_switching_supported"],
+        )
+
+    return role_session_router.route_task_session(
+        task_type,
+        active_profile=profile["profile_name"],
+        active_role_kind=active_role,
+        allowed_in_current_session=False,
+    )
+
+
 @mcp.tool()
 def gitea_resolve_task_capability(
     task: str,
@@ -3528,6 +3593,18 @@ def gitea_resolve_task_capability(
             "permission": "gitea.pr.merge",
             "role": "reviewer",
         },
+        "blind_pr_queue_review": {
+            "permission": "gitea.pr.review",
+            "role": "reviewer",
+        },
+        "request_changes_pr": {
+            "permission": "gitea.pr.request_changes",
+            "role": "reviewer",
+        },
+        "approve_pr": {
+            "permission": "gitea.pr.approve",
+            "role": "reviewer",
+        },
         "delete_branch": {
             "permission": "gitea.branch.delete",
             "role": "author",