Allow read-only PR queue inventory under author profiles while preserving hard review/merge gates

tests/test_pr_queue_inventory.py

@@ -0,0 +1,173 @@
+import os
+import sys
+import unittest
+import re
+from unittest.mock import patch, MagicMock
+
+sys.path.insert(0, str(__import__("pathlib").Path(__file__).resolve().parent.parent))
+
+from mcp_server import (
+    gitea_list_prs,
+    gitea_review_pr,
+    gitea_check_pr_eligibility,
+)
+import gitea_config
+
+FAKE_AUTH = "Basic dGVzdDp0ZXN0"
+
+class TestPRQueueInventory(unittest.TestCase):
+
+    @patch("mcp_server.api_get_all")
+    @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
+    @patch("mcp_server.get_profile")
+    def test_author_profile_can_list_open_prs(self, mock_get_profile, _auth, mock_get_all):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-author",
+            "allowed_operations": ["read", "gitea.pr.comment"],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        mock_get_all.return_value = [
+            {"number": 1, "title": "PR 1", "state": "open", "head": {"ref": "branch1", "sha": "abc1"}, "base": {"ref": "master"}, "mergeable": True}
+        ]
+        result = gitea_list_prs(state="open", remote="prgs")
+        self.assertEqual(len(result), 1)
+        self.assertEqual(result[0]["number"], 1)
+
+    @patch("mcp_server.api_get_all")
+    @patch("mcp_server.api_request")
+    @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
+    @patch("mcp_server.get_profile")
+    @patch("gitea_config.is_runtime_switching_enabled", return_value=True)
+    def test_author_profile_can_produce_pending_reviewer_queue_report(self, mock_switch, mock_get_profile, _auth, mock_api, mock_get_all):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-author",
+            "allowed_operations": ["read"],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        mock_get_all.return_value = [
+            {
+                "number": 1,
+                "title": "PR 1",
+                "state": "open",
+                "head": {"ref": "branch1", "sha": "abc1"},
+                "base": {"ref": "master"},
+                "mergeable": True,
+                "user": {"login": "jcwalker3"},
+                "labels": [{"name": "bug"}],
+                "body": "Fixes #10"
+            },
+            {
+                "number": 2,
+                "title": "PR 2",
+                "state": "open",
+                "head": {"ref": "branch2", "sha": "abc2"},
+                "base": {"ref": "master"},
+                "mergeable": True,
+                "user": {"login": "other_user"},
+                "labels": [],
+                "body": ""
+            }
+        ]
+        mock_api.return_value = {"login": "jcwalker3"} # whoami
+
+        result = gitea_review_pr(pr_number=1, event="APPROVE", remote="prgs")
+        self.assertFalse(result["success"])
+        self.assertIn("=== PR Queue Inventory ===", result["message"])
+        self.assertIn("Open PRs found: 2", result["message"])
+        self.assertIn("Review/merge blocked (Self-author). Requires a genuine non-author reviewer", result["message"])
+        self.assertIn("Review/merge blocked (Current profile is Author)", result["message"])
+        self.assertIn("gitea_activate_profile", result["message"])
+
+    @patch("mcp_server.api_get_all")
+    @patch("mcp_server.api_request")
+    @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
+    @patch("mcp_server.get_profile")
+    def test_author_profile_never_calls_mutation_tools_during_inventory(self, mock_get_profile, _auth, mock_api, mock_get_all):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-author",
+            "allowed_operations": ["read"],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        mock_get_all.return_value = []
+        mock_api.return_value = {"login": "jcwalker3"}
+
+        gitea_review_pr(pr_number=1, event="APPROVE", remote="prgs")
+        for call in mock_api.call_args_list:
+            method = call.args[0]
+            self.assertEqual(method, "GET")
+
+    @patch("mcp_server.api_get_all")
+    @patch("mcp_server.api_request")
+    @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
+    @patch("mcp_server.get_profile")
+    def test_reviewer_profile_can_proceed_from_inventory_to_review_gates(self, mock_get_profile, _auth, mock_api, mock_get_all):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-reviewer",
+            "allowed_operations": ["read", "approve", "review"],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        mock_get_all.return_value = [
+            {"number": 1, "title": "PR 1", "state": "open", "head": {"ref": "branch1", "sha": "abc1"}, "base": {"ref": "master"}, "mergeable": True, "user": {"login": "other_user"}}
+        ]
+        # mock_api: 1) /user (inventory), 2) /user (eligibility), 3) /pulls/1 (eligibility), 4) /pulls/1/reviews (POST review)
+        mock_api.side_effect = [
+            {"login": "reviewer1"}, # inventory whoami
+            {"login": "reviewer1"}, # eligibility whoami
+            {"state": "open", "head": {"sha": "abc1"}, "mergeable": True, "user": {"login": "other_user"}}, # eligibility PR details
+            {"id": 100} # POST review
+        ]
+
+        result = gitea_review_pr(pr_number=1, event="APPROVE", remote="prgs")
+        self.assertTrue(result["success"])
+        self.assertIn("Successfully submitted review", result["message"])
+
+    @patch("mcp_server.api_get_all")
+    @patch("mcp_server.api_request")
+    @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
+    @patch("mcp_server.get_profile")
+    @patch("gitea_config.is_runtime_switching_enabled", return_value=False)
+    def test_static_runtime_rejects_or_hides_profile_activation(self, mock_switch, mock_get_profile, _auth, mock_api, mock_get_all):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-author",
+            "allowed_operations": ["read"],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        mock_get_all.return_value = []
+        mock_api.return_value = {"login": "jcwalker3"}
+
+        result = gitea_review_pr(pr_number=1, event="APPROVE", remote="prgs")
+        self.assertFalse(result["success"])
+        self.assertNotIn("gitea_activate_profile", result["message"])
+        self.assertIn("Switch to the reviewer MCP session", result["message"])
+
+    @patch("mcp_server.get_profile")
+    def test_stopped_before_listing_is_not_reported_as_no_prs(self, mock_get_profile):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-restricted",
+            "allowed_operations": [],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        result = gitea_review_pr(pr_number=1, event="APPROVE", remote="prgs")
+        self.assertFalse(result["success"])
+        self.assertIn("PR inventory not attempted", result["message"])
+        self.assertNotIn("Open PRs found: 0", result["message"])
+
+    @patch("mcp_server.api_request")
+    @patch("mcp_server.get_auth_header", return_value=FAKE_AUTH)
+    @patch("mcp_server.get_profile")
+    def test_reviewer_eligibility_check_not_run_for_author_profile(self, mock_get_profile, _auth, mock_api):
+        mock_get_profile.return_value = {
+            "profile_name": "gitea-author",
+            "allowed_operations": ["read"],
+            "forbidden_operations": [],
+            "base_url": None,
+        }
+        result = gitea_check_pr_eligibility(pr_number=1, action="approve", remote="prgs")
+        self.assertFalse(result["eligible"])
+        self.assertEqual(mock_api.call_count, 0)