merge: resolve PR #335 conflicts with master (fd396df)

Keep master router-style SKILL.md (full #333 split) and merge #334
review-merge test coverage into test_llm_workflow_split.py.

Conflicts resolved in:
- skills/llm-project-workflow/SKILL.md
- tests/test_llm_workflow_split.py

tests/test_llm_workflow_split.py

@@ -3,15 +3,62 @@ from pathlib import Path
 
 REPO_ROOT = Path(__file__).resolve().parent.parent
 SKILL_DIR = REPO_ROOT / "skills" / "llm-project-workflow"
+SKILL = (SKILL_DIR / "SKILL.md").read_text(encoding="utf-8")
 
 
-def test_review_merge_workflow_file_exists():
-    path = SKILL_DIR / "workflows" / "review-merge-pr.md"
-    text = path.read_text(encoding="utf-8")
+def test_skill_md_exists():
+    assert SKILL_DIR.joinpath("SKILL.md").is_file()
+
+
+def test_all_workflow_files_exist():
+    for name in (
+        "review-merge-pr.md",
+        "reconcile-landed-pr.md",
+        "create-issue.md",
+        "work-issue.md",
+    ):
+        assert (SKILL_DIR / "workflows" / name).is_file(), name
+
+
+def test_skill_references_all_workflow_files():
+    for name in (
+        "workflows/review-merge-pr.md",
+        "workflows/reconcile-landed-pr.md",
+        "workflows/create-issue.md",
+        "workflows/work-issue.md",
+    ):
+        assert name in SKILL
+
+
+def test_skill_contains_mode_isolation_language():
+    assert "## Mode isolation" in SKILL
+    assert "review-merge-pr" in SKILL
+    assert "reconcile-landed-pr" in SKILL
+    assert "create-issue" in SKILL
+    assert "work-issue" in SKILL
+    assert "Do not mix modes" in SKILL or "do not mix modes" in SKILL.lower()
+
+
+def test_skill_is_router_not_monolithic_review_body():
+    assert "This skill is a **router**" in SKILL or "router" in SKILL.lower()
+    assert "## F. Review workflow" not in SKILL
+    assert "gitea_mark_final_review_decision" not in SKILL
+    assert "gitea_submit_pr_review" not in SKILL
+
+
+def test_skill_still_declares_controller_handoff_contract():
+    assert "## Controller Handoff" in SKILL
+    assert "assess_controller_handoff" in SKILL
+    assert "## Global LLM Worktree Rule" in SKILL
+
+
+def test_review_merge_workflow_contract():
+    text = (SKILL_DIR / "workflows" / "review-merge-pr.md").read_text(encoding="utf-8")
     assert "canonical: true" in text
-    assert "review-merge-pr" in text
     assert "## 0. Load the canonical workflow first" in text
     assert "## 26A. Terminal review mutation hard-stop" in text
+    assert "## 11A. Skipped PRs are read-only" in text
+    assert "## 35. Duplicate request-changes prevention" in text
     assert "## 37. Controller handoff schema" in text
     assert "INVENTORY_PAGINATION_UNPROVEN" in text
     assert "ALREADY_LANDED_RECONCILE_REQUIRED" in text
@@ -23,29 +70,49 @@ def test_review_merge_final_report_schema_exists():
     assert "Controller Handoff" in text
     assert "Candidate head SHA:" in text
     assert "Terminal review mutation:" in text
-    assert "Workspace mutations" in text  # documented as rejected
+    assert "Workspace mutations" in text
 
 
-def test_skill_router_points_to_review_merge_workflow():
-    skill = (SKILL_DIR / "SKILL.md").read_text(encoding="utf-8")
-    assert "## Task mode router" in skill
-    assert "workflows/review-merge-pr.md" in skill
-    assert "schemas/review-merge-final-report.md" in skill
-    assert "Identify task mode before any mutation" in skill
+def test_reconcile_landed_workflow_contract():
+    text = (SKILL_DIR / "workflows" / "reconcile-landed-pr.md").read_text(encoding="utf-8")
+    assert "canonical: true" in text
+    assert "Do not review or merge normal PRs" in text
+    assert "Already-landed proof" in text
 
 
-def test_skill_still_declares_controller_handoff_contract():
-    skill = (SKILL_DIR / "SKILL.md").read_text(encoding="utf-8")
-    assert "## Controller Handoff" in skill
-    assert "assess_controller_handoff" in skill
-    assert "## Global LLM Worktree Rule" in skill
+def test_create_issue_workflow_contract():
+    text = (SKILL_DIR / "workflows" / "create-issue.md").read_text(encoding="utf-8")
+    assert "canonical: true" in text
+    assert "## 9. Duplicate search before mutation" in text
 
 
-def test_review_pr_template_references_extracted_workflow():
+def test_work_issue_workflow_contract():
+    text = (SKILL_DIR / "workflows" / "work-issue.md").read_text(encoding="utf-8")
+    assert "canonical: true" in text
+    assert "Do not merge your own PR" in text
+    assert "## 21. PR creation rules" in text
+
+
+def test_final_report_schemas_exist():
+    for name in (
+        "review-merge-final-report.md",
+        "reconcile-landed-final-report.md",
+        "create-issue-final-report.md",
+        "work-issue-final-report.md",
+    ):
+        assert (SKILL_DIR / "schemas" / name).is_file(), name
+
+
+def test_review_pr_template_references_workflow():
     text = (SKILL_DIR / "templates" / "review-pr.md").read_text(encoding="utf-8")
     assert "workflows/review-merge-pr.md" in text
 
 
-def test_merge_pr_template_references_extracted_workflow():
+def test_merge_pr_template_references_workflow():
     text = (SKILL_DIR / "templates" / "merge-pr.md").read_text(encoding="utf-8")
-    assert "workflows/review-merge-pr.md" in text
+    assert "workflows/review-merge-pr.md" in text
+
+
+def test_start_issue_template_references_work_issue_workflow():
+    text = (SKILL_DIR / "templates" / "start-issue.md").read_text(encoding="utf-8")
+    assert "workflows/work-issue.md" in text