feat: require validation cwd and HEAD proof in reviewer reports (Closes #398)

Rebased onto current prgs/master; merged with #396 validation failure history by keeping both validator rules and workflow handoff fields. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
2026-07-07 13:09:58 -04:00
parent 1a1e679246
commit 1320a55a7e
6 changed files with 441 additions and 0 deletions
@@ -604,6 +604,28 @@ Do not claim “full-suite failures are pre-existing” unless baseline proof is

 ## 23. Validation command proof rule

+Before any diff, test, or compile validation, record in the same command
+transcript or final report:
+
+* `pwd` or explicit working directory
+* `git rev-parse HEAD`
+* `git status --short --branch`
+* expected PR head SHA (candidate head SHA)
+
+Validation commands must use one of:
+
+* `git -C <review_worktree> ...`
+* `cd <review_worktree> && ...` in the same command
+* tool-provided explicit working-directory metadata
+
+Do not rely on inferred shell cwd from a prior command in a different block.
+
+`gitea_validate_review_final_report` rejects validation claims without
+cwd/HEAD proof when `validation_session` is supplied.
+
+Baseline validation must document baseline worktree path, baseline target SHA,
+cwd proof, exact baseline command, and baseline result using the same rules.
+
 Report the exact validation command as executed.

 Report the working directory where validation ran.
@@ -1127,6 +1149,7 @@ Controller Handoff:
 * Files reviewed:
 * Validation:
 * Validation failure history:
+* Validation cwd/HEAD proof:
 * Official validation integrity status:
 * Terminal review mutation:
 * Review decision: